jDownloads Support Forum

jDownloads for Joomla 4.x and 5.x => jDownloads 4.0 => Suggestions - Feature Request => Topic started by: Jefferson49 on 09.02.2023 06:42:42

Title: Typo or wrong German translation in "Download details" - [Corrected!]
Post by: Jefferson49 on 09.02.2023 06:42:42
- Joomla: 4.2.7
- jD 4.0.16 Beta
- PHP: 8.0.23
- Standard backend template: jD yes, Joomla Atum
- New Joomla 4 installation

After updating from jD 3.9 to jD 4.0.16 beta, there seems to be a typo or wrong German translation in "Download details, see screen shot.
Title: Re: Typo or wrong German translation in "Download details" - [No Bug]
Post by: Arno on 09.02.2023 16:40:03
Sorry, aber das ist für mich kein Fehler (und ein Bug sowieso nicht):
Das Wort bedeutet im Englischen und im Deutschen eigentlich dasselbe.
Man könnte vielleicht auch Einzelheiten schreiben, klingt für mich aber irgendwie nicht wirklich passend.
Vielleicht wäre Beschreibung im Detail noch passender. Oder Komplette Download Beschreibung. Wäre mir aber zu lang.

Ich verschieb das mal zu Verbesserungsvorschläge.
Title: Re: Typo or wrong German translation in "Download details"
Post by: Jefferson49 on 10.02.2023 07:19:03
I completely agree that it is no major bug. However, the German translation has a typo at least. Should be "Download-Details" instead of "Download details".

I found out that this already exists in JD 3.9.

In transifex 3.9 it seems to be correct, see also screenshot:
en-GB "Download details" => de-DE "Download-Details"

However, in the translation of the deployment, it seems to be wrong:
line 80 of: com_jdownloads_beta_4_0_16\com_jdownloads\site\language\de-DE\de-DE.com_jdownloads.ini
COM_JDOWNLOADS_FRONTEND_SUBTITLE_OVER_DETAIL="Download details"

With inspection by the browser developer tools and a search in the PHP code, I found it the related code here:
line 1043 of: \com_jdownloads_beta_4_0_16\com_jdownloads\admin\src\Helper\StandardLayouts.php
$details_subheader = '<div class="jd_cat_subheader" style="font-weight: bold;">{detail_title}</div><!-- Details layout subheader -->';